Disable attachment upload on federated shares #7154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
commented
Apr 28, 2025
max-nextcloud
force-pushed
the
fix/7092-no-attachments-for-federated-shares
branch
2 times, most recently
from
4e0a23d to
76c5518
Compare
max-nextcloud
changed the title
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
max-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
max-nextcloud
force-pushed
the
fix/7092-no-attachments-for-federated-shares
branch
from
76c5518 to
4528a93
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7154 +/- ##
==========================================
+ Coverage 51.94% 52.41% +0.47%
==========================================
Files 479 479
Lines 41457 41508 +51
Branches 1002 1024 +22
==========================================
+ Hits 21534 21757 +223
+ Misses 19817 19649 -168
+ Partials 106 102 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Files without an owner such as federated shares cannot receive attachments as the attachment would need to be stored in the owners user folder. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/7092-no-attachments-for-federated-shares
branch
from
4528a93 to
180564d
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/7092-no-attachments-for-federated-shares
branch
from
180564d to
8b9c8fa
Compare
max-nextcloud
changed the title
mejo-
approved these changes
May 6, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Didn't test, but the code changes look sensible to me. Extra kudos for the tests 🧪
Collaborator
Author
|
/backport to stable31 |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📝 Office team
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7092
Files without an owner such as federated shares
cannot receive attachments
as the attachment would need to be stored in the owners user folder.
TODO:
syncService.hasOwner